Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update proto marshaler from gogo to std #469

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

rustatian
Copy link
Collaborator

Reason for This PR

  • Replay WF error when using old gogo-proto encoded history.

Description of Changes

  • Remove gogo proto, update with the standard (google/protobuf) json marshaler.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added B-bug Bug: bug, unhandled exception C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Feb 16, 2024
@rustatian rustatian self-assigned this Feb 16, 2024
@rustatian rustatian merged commit 59ce045 into master Feb 16, 2024
10 checks passed
@rustatian rustatian deleted the fix/remove-gogo-proto branch February 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, unhandled exception C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants