Make sure OTel exporter can work properly with TLS #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 22, 2024
|
(Sorry we broke this in tonic -- will be fixed in 0.12.2, to be released soon.) |
Sushisource
added a commit
that referenced
this pull request
Sep 3, 2024
(cherry picked from commit ae98adb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add proper (newly needed) TLS config to OTel exporter
Why?
Needed for anyone with external collectors, like datadog etc.
Checklist
Closes [Bug] OpenTelemetry export fails over TLS #801
How was this tested:
Added a test (which needs to be run manually right now, will add to CI later)
Any docs updates needed?