Workflow completion command reordering #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Jun 10, 2024
cretz
commented
Jun 10, 2024
| @@ -1402,6 +1385,71 @@ private string GetStackTrace() | |||
| }).Where(s => !string.IsNullOrEmpty(s)).Select(s => $"Task waiting at:\n{s}")); | |||
| } | |||
|
|
|||
| private void ApplyCompletionCommandReordering( | |||
There was a problem hiding this comment.
Looking for review of this method
cretz
force-pushed
the
workflow-complete-reorder
branch
from
46bf93f
to
f221849
Compare
cretz
force-pushed
the
workflow-complete-reorder
branch
from
f221849
to
046023c
Compare
Sushisource
approved these changes
Jun 10, 2024
Quinn-With-Two-Ns
approved these changes
Jun 10, 2024
|
Thanks for looking at this! Not sure anyone else is, so I am merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
See temporalio/features#481. Like other core-based SDKs, .NET put the workflow complete command on the command list immediately when it occurred from workflow return. And then it truncated anything else after that. So coroutines that completed in the same task but after workflow method return were dropped.
This issue changes that behavior to enure same-task-post-complete coroutine commands are preserved. The approach that is taken now is that, if we are not replaying (or replaying w/ SDK flag set) and there are commands after return, move the return to the end and set an SDK flag. Otherwise do as done today. This not only ensures that workflow completion comes last, but the checking for whether any post-complete commands even exist allow us to not set this flag.
(there is also a somewhat unrelated fix to a flaky user-client-replacement test)
Checklist