Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nexus support to TestWorkflowExtension #2238

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Add Nexus support to TestWorkflowExtension #2238

merged 6 commits into from
Sep 25, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add Nexus support to TestWorkflowExtension. This PR also adds support to automatically create a Nexus Endpoint in the TestWorkflowExtension to make testing easier.

closes: #2235

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner September 24, 2024 22:12
@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this pull request Sep 24, 2024
Merged
cretz
cretz approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there's no real cost to creating the endpoint by default, makes sense to me

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 8d7b3cd into temporalio:nexus Sep 25, 2024
7 checks passed
Quinn-With-Two-Ns added a commit that referenced this pull request Oct 3, 2024
@Quinn-With-Two-Ns
Add Nexus support to TestWorkflowExtension (#2238)
364c5f6 
Add Nexus support to TestWorkflowExtension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @bergundy @cretz