Skip to content

Commit

Permalink
Fixes bug where we were not persisting the failure details for a mark…
Browse files Browse the repository at this point in the history
…er recorded event, which corrupts workflow on replay #712

We are not persisting the failure details on an incoming RecordLocalMarkerCommand. As a result on replay, if we have recorded a local activity failure, the SDK will panic since the expected failure field is missing.
  • Loading branch information
mastermanu authored Sep 5, 2020
1 parent 50de8a2 commit 02ab64c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions service/history/historyBuilder.go
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ func (b *historyBuilder) newMarkerRecordedEventAttributes(workflowTaskCompletedE
attributes.Details = request.Details
attributes.WorkflowTaskCompletedEventId = workflowTaskCompletedEventID
attributes.Header = request.Header
attributes.Failure = request.Failure
historyEvent.Attributes = &historypb.HistoryEvent_MarkerRecordedEventAttributes{MarkerRecordedEventAttributes: attributes}

return historyEvent
Expand Down

0 comments on commit 02ab64c

Please sign in to comment.