Set default ES bulk processor ack timeout to 1 minute (#1210)

temporalio · Jan 21, 2021 · 1428a3d · 1428a3d
1 parent b46fbe3
commit 1428a3d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/common/persistence/elasticsearch/esVisibilityStore_test.go b/common/persistence/elasticsearch/esVisibilityStore_test.go
@@ -112,7 +112,7 @@ func (s *ESVisibilitySuite) SetupTest() {
 	cfg := &config.VisibilityConfig{
 		ESIndexMaxResultWindow: dynamicconfig.GetIntPropertyFn(3),
 		ValidSearchAttributes:  dynamicconfig.GetMapPropertyFn(definition.GetDefaultIndexedKeys()),
-		ESProcessorAckTimeout:  dynamicconfig.GetDurationPropertyFn(5 * time.Second),
+		ESProcessorAckTimeout:  dynamicconfig.GetDurationPropertyFn(1 * time.Minute),
 	}
 
 	s.mockMetricsClient = &metricsmocks.Client{}

diff --git a/host/testcluster.go b/host/testcluster.go
@@ -182,7 +182,7 @@ func NewCluster(options *TestClusterConfig, logger log.Logger) (*TestCluster, er
 			VisibilityListMaxQPS:   dynamicconfig.GetIntPropertyFilteredByNamespace(2000),
 			ESIndexMaxResultWindow: dynamicconfig.GetIntPropertyFn(defaultTestValueOfESIndexMaxResultWindow),
 			ValidSearchAttributes:  dynamicconfig.GetMapPropertyFn(definition.GetDefaultIndexedKeys()),
-			ESProcessorAckTimeout:  dynamicconfig.GetDurationPropertyFn(5 * time.Second),
+			ESProcessorAckTimeout:  dynamicconfig.GetDurationPropertyFn(1 * time.Minute),
 		}
 		indexName := options.ESConfig.Indices[common.VisibilityAppName]
 		esVisibilityStore := pes.NewElasticSearchVisibilityStore(esClient, indexName, nil, esProcessor, visConfig, logger, &metricsmocks.Client{})

diff --git a/service/history/configs/config.go b/service/history/configs/config.go
@@ -447,7 +447,7 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis
 		ESProcessorBulkActions:            dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 1000),
 		ESProcessorBulkSize:               dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 2<<24), // 16MB
 		ESProcessorFlushInterval:          dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 1*time.Second),
-		ESProcessorAckTimeout:             dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 5*time.Second),
+		ESProcessorAckTimeout:             dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
 	}
 
 	return cfg

diff --git a/tools/cli/namespaceUtils.go b/tools/cli/namespaceUtils.go
@@ -293,7 +293,7 @@ func initializeMetadataMgr(
 	pConfig.VisibilityConfig = &config.VisibilityConfig{
 		VisibilityListMaxQPS:  dynamicconfig.GetIntPropertyFilteredByNamespace(dependencyMaxQPS),
 		EnableSampling:        dynamicconfig.GetBoolPropertyFn(false), // not used by namespace operation
-		ESProcessorAckTimeout: dynamicconfig.GetDurationPropertyFn(5 * time.Second),
+		ESProcessorAckTimeout: dynamicconfig.GetDurationPropertyFn(1 * time.Minute),
 	}
 	pFactory := client.NewFactory(
 		&pConfig,