Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra Consistency and SerialConsistency should be configurable #512

Closed
rfwagner opened this issue Jul 8, 2020 · 1 comment · Fixed by #533
Closed

Cassandra Consistency and SerialConsistency should be configurable #512

rfwagner opened this issue Jul 8, 2020 · 1 comment · Fixed by #533
Labels
enhancement New feature or request

Comments

@rfwagner
Copy link

rfwagner commented Jul 8, 2020

There are 10 or so places throughout the Temporal code base where a gocql.ClusterConfig struct is created in order to create a new Cassandra session. In each location, the Consistency and SerialConsistency levels are hardcoded, e.g.:

	cluster.Consistency = gocql.LocalQuorum
	cluster.SerialConsistency = gocql.LocalSerial

These consistency levels should both be configurable. They should be made part of the Config.Cassandra struct which holds existing configurable Cassandra settings like username, password, keyspace name etc.

Ultimately these should be settable in the yaml config with something like:


    persistence:
      defaultStore: cass-default
      visibilityStore: cass-visibility
      numHistoryShards: 4
      datastores:
        cass-default:
          cassandra:
            keyspace: mykeyspace
            user: myuser
            consistency: Quorum
            serialConsistency: Serial
            ...

@rfwagner rfwagner added the enhancement New feature or request label Jul 8, 2020
@mastermanu
Copy link
Member

Thanks for the suggestion!

A change for this was merged to master yesterday: https://github.com/temporalio/temporal/blob/master/common/service/config/config.go#L242

We've also updated our helm chart to indicate how to specify these: https://github.com/temporalio/helm-charts/blob/master/values.yaml#L94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants