Expose cassandra consistency and serial consistency settings in configuration #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
commented
Jul 12, 2020
common/service/config/persistence.go
Outdated
| @@ -66,3 +76,95 @@ func (c *Persistence) Validate() error { | |||
| func (c *Persistence) IsAdvancedVisibilityConfigExist() bool { | |||
| return len(c.AdvancedVisibilityStore) != 0 | |||
| } | |||
|
|
|||
| // GetConsistency returns the gosql.Consistency setting from the configuration for the store | |||
| func (c *CassandraConsistencySettings) GetConsistency() gocql.Consistency { | |||
There was a problem hiding this comment.
Could also consider moving these to a separate cassandra specific file. Am on the fence.
mastermanu
commented
Jul 13, 2020
mastermanu
commented
Jul 13, 2020
mastermanu
commented
Jul 13, 2020
shawnhathaway
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables an end-user to configure consistency and serial consistency for their Cassandra Datastores. The behavior is as follows:
If the user chooses not to set this at all, we default to local_quorum and local_serial respectively.
The user can choose to set a "default" that applies to ALL stores.
We have not exposed a configuration setting for the Cassandra admin tool, which defaults to ALL for the Quorum level.
It is an open question on whether we want to expose one configuration knob per store, or expose a few configuration knobs, some of which apply to a set of stores. There may also be stores which we don't want to expose any kind of knob for. We can have this discussion via PR comments or offline.
A whole slew of unit tests were added that provide 100% code coverage for the added configuration code, and the existing persistence tests ran after ensuring validate was called. Also ran the server locally and tested putting in different values for a few different stores.