Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics scope namespace tag initialization #1223

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fix metrics scope namespace tag initialization #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8e9b80
Fix metrics scope namespace tag initialization
wxing1292 Jan 26, 2021
b57f937
Merge branch 'master' into metrics
wxing1292 Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/metrics/interfaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
)

type (
// Client is the interface used to report metrics tally.
// Client is the interface used to report metrics tally.
Client interface {
// IncCounter increments a counter metric
IncCounter(scope int, counter int)
Expand Down
2 changes: 1 addition & 1 deletion common/metrics/scope.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (m *metricsScope) RecordHistogramValue(id int, value float64) {
}

func (m *metricsScope) Tagged(tags ...Tag) Scope {
namespaceTagged := false
namespaceTagged := m.isNamespaceTagged
tagMap := make(map[string]string, len(tags))
for _, tag := range tags {
if isNamespaceTagged(tag) {
Expand Down