Improve ES logging #1228
Merged
Improve ES logging #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jan 26, 2021
| } | ||
|
|
||
| p.logger.Info("Adding duplicate visibility task to ES bulk processor.", tag.Value(key)) | ||
| p.logger.Warn("Adding duplicate ES request for visibility task key.", tag.Key(visibilityTaskKey), tag.ESDocID(request.ID), tag.Value(request.Doc)) |
There was a problem hiding this comment.
For easy grep "ES request".
wxing1292
reviewed
Jan 26, 2021
wxing1292
approved these changes
Jan 26, 2021
alexshtin
force-pushed
the
feature/es-logging-remove
branch
from
00edddc
to
f1ebb87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
logLevelto ES config with possible values:error(default),info,trace, anddisabled.Why?
Improve ES logging for better debug expirience.
How did you test it?
Run locally and observed trace level logs.
Potential risks
No risks.