Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kafka message usage from admin ES index command #1356

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Remove Kafka message usage from admin ES index command #1356

merged 2 commits into from
Mar 5, 2021

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Mar 5, 2021 •
edited
Loading

What changed?
persistence.RecordWorkflowExecutionClosedRequest is used instead of indexerspb.Message in tctl admin es index command.

Why?
Prepare to remove Kafka and indexerspb.Message from the code.

How did you test it?
Run tctl manually locally.

Potential risks
tctl admin es index input file format is changed.

Is hotfix candidate?
No.

@alexshtin alexshtin requested review from a team and wxing1292 March 5, 2021 02:31
@alexshtin alexshtin merged commit 31650b5 into temporalio:master Mar 5, 2021
@alexshtin alexshtin deleted the feature/admin-es-index branch March 5, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexshtin @wxing1292