Remove SHELL var override to fix Makefile multi-line execution #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you update the title to clearly state the value that the work adds, ex Then tech details can be mentioned in the description if needed |
feedmeapples
approved these changes
Mar 17, 2021
alexshtin
changed the title
wxing1292
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove
SHELLvar override to fixMakefilemulti-line execution.Why?
Overridden
SHELLcaused problems with multiline statements. The only reason it was used for is addGOBINtoPATHwhich can be achieved with simplePATHoverride.How did you test it?
Run locally.
Potential risks
No risks.
Is hotfix candidate?
No.