Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistency to admin cli command names #427

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Add consistency to admin cli command names #427

merged 2 commits into from
Jun 4, 2020

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Jun 3, 2020

What changed?
Changed the names of admin CLI commands to be consistent between each other

Why?
Was confusing having commands in completely different naming patterns

How did you test it?
ran commands

Potential risks
Changes the API of Admin CLI - requires checking the new names. No other risks

Copy link
Contributor

@rylandg rylandg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we just agree that there should be no underscores in these comands? Why not dashes?

@feedmeapples
Copy link
Contributor Author

feedmeapples commented Jun 3, 2020

ands? Why not dashes?
Didn't we just agree that there should be no underscores in these comands? Why not dashes?

I don't want to just partially switch to dashes here in admin commands. I believe we should change to dashes everywhere at once: commands and options in both tctl and admin. This PR is not really about the dashes but consistency in naming pattern

@shawnhathaway
Copy link
Contributor

Didn't we just agree that there should be no underscores in these comands? Why not dashes?

I don't want to just partially switch to dashes here in admin commands. I believe we should change to dashes everywhere at once: commands and options in both tctl and admin. This PR is not really about the dashes but consistency in naming pattern

Do we plan to do this before release? Are we tracking anywhere?

@feedmeapples
Copy link
Contributor Author

feedmeapples commented Jun 3, 2020

Do we plan to do this before release? Are we tracking anywhere?

there is this proposal in stage 1 temporalio/proposals#12
and a task https://app.clubhouse.io/temporal-technologies-inc/story/548/cli-use-hyphens-as-delimiters-instead-of-underscores

@feedmeapples feedmeapples requested a review from rylandg June 3, 2020 23:23
@feedmeapples feedmeapples merged commit 8aa47f4 into temporalio:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants