Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CLI util for list commands #443

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Create CLI util for list commands #443

merged 3 commits into from
Jun 11, 2020

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Jun 10, 2020

What changed?
Added a CLI util that allows to control the printing of items: interactive printing, printing everything at once, starting from a given page token. Can be extended to also control printing as table/json

Why
Helps to avoid repetition of the same list commands specific code. Makes it easier to support the code since it can be shared by all of the list commands

How did you test it?
Ran the commands and tests

Potential risks
No risks

@feedmeapples feedmeapples changed the title Create CLI util to interactively print lists Create CLI util for list commands Jun 10, 2020
@feedmeapples feedmeapples marked this pull request as draft June 10, 2020 17:35
@feedmeapples feedmeapples marked this pull request as ready for review June 10, 2020 17:49
@feedmeapples feedmeapples merged commit 40c0eb9 into temporalio:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants