Add table-view support for CLI list commands #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jun 16, 2020
alexshtin
reviewed
Jun 16, 2020
alexshtin
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added Table view to CLI list util in addition to JSON view. Use --print_json to switch between them. Default is Table view.
Why?
Allows to switch between table and json view for CLI list commands.
How did you test it?
Ran tests and a list command that utilizes the new util. Example:
./tctl admin shard list_tasks --shard_id 3 --task_type 3 --pagesize 4 --more --print_json --username <db_flags>Potential risks
Smaller risk of not properly handling a field of a row since the table view constructs the table dynamically using reflection