Change CLI task_type option to string value from int #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
changed the title
feedmeapples
changed the title
feedmeapples
changed the title
alexshtin
changed the title
alexshtin
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed the type of task_type option from int to string
Why?
Makes CLI experience friendlier by allowing users to type task type name (replication, transfer, timer) instead of obscure integers (0,1,3)
How did you test it?
Ran tests and commands
Potential risks
Incompatible change, old task CLI commands will stop working and require to change to string values