Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten Ringpop Join Params #446

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Tighten Ringpop Join Params #446

merged 6 commits into from
Jun 29, 2020

Conversation

shawnhathaway
Copy link
Contributor

@shawnhathaway shawnhathaway commented Jun 11, 2020 •
edited
Loading

What changed?

  • Parallelism Factor: 2 -> 10 and Join Size: 3 -> 1
    • This ensures we can join a two node cluster.
    • This will also help in the case that IP addresses are changing on restart to allow us to go through a larger number of candidates
  • Reduce heartbeat sleep interval and add jitter to prevent all nodes aligning (Heartbeat every 10-15 Seconds)
  • Heartbeat cutoff time for reading candidate seed nodes reduced to 20 seconds.

How did you test it?
Ringpop unit tests

Potential risks
This shouldn't add additional risk.

@alexshtin alexshtin self-requested a review June 18, 2020 17:05
@shawnhathaway shawnhathaway merged commit 4ca4935 into temporalio:master Jun 29, 2020
@shawnhathaway shawnhathaway deleted the ringpop_params branch June 29, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@samarabbas samarabbas Awaiting requested review from samarabbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnhathaway @alexshtin