Remove query consistency level from request #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jun 13, 2020
| if request.GetRequest().GetQueryConsistencyLevel() == enumspb.QUERY_CONSISTENCY_LEVEL_STRONG && !consistentQueryEnabled { | ||
| return nil, ErrConsistentQueryNotEnabled | ||
| } | ||
| queryConsistencyLevel := enumspb.QUERY_CONSISTENCY_LEVEL_STRONG |
There was a problem hiding this comment.
Left this as never change local var here in case if we decide to bring it back one day.
| }, | ||
| } | ||
| resp, err := s.mockHistoryEngine.QueryWorkflow(context.Background(), request) | ||
| s.Equal(ErrQueryWorkflowBeforeFirstDecision, err) |
There was a problem hiding this comment.
This error was returned only from eventual consistency block.
Comment on lines
-655
to
-656
| di = addDecisionTaskScheduledEvent(msBuilder) | ||
| addDecisionTaskStartedEvent(msBuilder, di.ScheduleID, tasklist, identity) |
There was a problem hiding this comment.
Only completed workflows can be queried directly through matching now.
mfateev
approved these changes
Jun 13, 2020
mfateev
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
QueryConsistencyLevelfield was removed fromQueryWorkflowrequest and dynamic config with default valueSTRONG.Why?
EVENTUALconsistency is not supported any more.How did you test it?
Run all tests.
Potential risks
No tests.