Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes up admin cluster command for adding search attributes to be indexed #514

Merged

Conversation

mastermanu
Copy link
Member

Changed the --search_attr_type flag to take in an English readable name (e.g. Keyword, Int, String, etc) instead of an integer (which is less intuitive and should be hidden from the end user anyway).

  • Fixes confusion for the user around which integer to map to the type of field they want indexed.
  • Removes the need to document the attribute type integer in our temporal docs (which just causes confusion)
  • Tested change locally against my developer environment. Verified addition of different types of attributes (int and keyword) and that search worked properly from the command-line.

tctl-only change. No server change here.

@alexshtin alexshtin changed the title fixes up admin cluster command for adding search attributes to be indexed Fixes up admin cluster command for adding search attributes to be indexed Jul 8, 2020
tools/cli/admin.go Outdated Show resolved Hide resolved
@mastermanu mastermanu merged commit 37f1b77 into temporalio:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants