Adopt Google api-linter #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
Jul 10, 2020
| @@ -12,10 +12,10 @@ all: update-tools clean proto bins check test | |||
| clean: clean-bins clean-test-results | |||
|
|
|||
| # Recompile proto files. | |||
| proto: clean-proto install-proto-submodule protoc fix-proto-path proto-mock goimports-proto | |||
| proto: clean-proto install-proto-submodule buf api-linter protoc fix-proto-path proto-mock goimports-proto | |||
There was a problem hiding this comment.
This looks like a huge PR but actually only Makefile and content of proto dir worth reviewing. All the rest is just mechanical replaces.
mfateev
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Google
api-linterwas added toMakefile. Also config fileapi-linter.yamlwas added toprotodir. I fixed some errors and added all the rest as exceptions to the config.Why?
Proto files need to comply with
api-linterrules.How did you test it?
Run all tests.
Potential risks
No risks.