Add support for arbitrary predicates for multi cursor queues #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
multi-cursor-predicate-cleanup
branch
from
ff13872
to
9a95fa7
Compare
| Predicate(keys []any) tasks.Predicate | ||
| } | ||
|
|
||
| type GrouperNamespaceID struct { |
There was a problem hiding this comment.
nit: What about GroupByNamespaceID instead? It reads a bit better imo
bergundy
force-pushed
the
multi-cursor-predicate-cleanup
branch
from
9a95fa7
to
2e7183a
Compare
yycptt
approved these changes
Jan 20, 2024
| @@ -531,6 +531,14 @@ func (e *executableImpl) SetScheduledTime(t time.Time) { | |||
| e.scheduledTime = t | |||
| } | |||
|
|
|||
| // GetDestination returns the embedded task's destination if it exists. Defaults to an empty string. | |||
| func (e *executableImpl) GetDestination() string { | |||
There was a problem hiding this comment.
nit: feels like it should be a method on tasks.Task, not executable. But I don't have strong opinion.
| @@ -135,6 +135,7 @@ func NewScheduledQueue( | |||
| options, | |||
| hostRateLimiter, | |||
| readerCompletionFn, | |||
| GrouperNamespaceID{}, | |||
There was a problem hiding this comment.
I think this should be a parameter as well...
There was a problem hiding this comment.
Let's wait for a use case, so far I don't see one.
service/history/queues/slice.go
Outdated
| if len(s.executableTracker.pendingPerNamespace) > shrinkPredicateMaxPendingNamespaces { | ||
| // TODO: this should be generic enough to shrink any predicate type, probably doesn't belong here. | ||
| pendingPerKey := s.executableTracker.pendingPerKey | ||
| if len(pendingPerKey) > shrinkPredicateMaxPendingKeys { | ||
| // only shrink predicate if there're few namespaces left |
There was a problem hiding this comment.
Suggested change
| // only shrink predicate if there're few namespaces left | |
| // only shrink predicate if there're few keys left |
service/history/queues/slice.go
Outdated
| namespacePredicate := tasks.NewNamespacePredicate(pendingNamespaceIDs) | ||
| s.scope.Predicate = tasks.AndPredicates(s.scope.Predicate, namespacePredicate) | ||
| minimalPredicate := s.grouper.Predicate(maps.Keys(pendingPerKey)) | ||
| s.scope.Predicate = tasks.AndPredicates(s.scope.Predicate, minimalPredicate) |
There was a problem hiding this comment.
now that I think about it, the tasks.AndPredicates looks unnecessary to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
We need this flexibility for Nexus, this is some of the prep work.
How did you test it?
Add some unit tests, ran existing tests.
Potential risks
We should look closely at this as it may mess up task processing multi-cursor logic.
Is hotfix candidate?
No.