Fix elastic search index name for ExecutionStatus #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 15, 2020
mastermanu
requested changes
Jul 15, 2020
mastermanu
approved these changes
Jul 15, 2020
mastermanu
reviewed
Jul 15, 2020
| @@ -13,7 +13,7 @@ frontend.validSearchAttributes: | |||
| StartTime: "Int" | |||
There was a problem hiding this comment.
the index_template.json has this as a long. Same with executiontime and closetime and customintfield
There was a problem hiding this comment.
Looks like proto definition only defines the following four types:
message Field {
temporal.server.api.enums.v1.FieldType type = 1;
oneof data {
string string_data = 2;
int64 int_data = 3;
bool bool_data = 4;
bytes binary_data = 5;
}
}
There was a problem hiding this comment.
hmm, then maybe we should just fix up index_template to use integer then (or maybe switch all of them to long if proto is int64)
samarabbas
force-pushed
the
fix-index-key-for-elastic-search
branch
from
4a31161
to
9e7e382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update index key definition for Elastic Search in development_es.yaml to reflect the recent renaming from
StatustoExecutionStatus.Why?
Recently we did massive renaming of ElasticSearch indexes. As part of this renaming
Statusindexcreated by the system to represent status of closed workflow execution was renamed to
ExecutionStatus. Default in the code is updated to represent this change but dynamic configoverride used by local development with ES support was not updated. This resulted in indexes to
go out of sync in all places which relies on development_es.yaml dynamic config file. This broke
local development setup and anyone using docker-compose_es.yaml.
How did you test it?
Locally run Temporal server using dynamic config overrides in development_es.yaml. Made sure
visibility is working after execution closes.
Potential risks
This should only impact local development setups with Elastic Search.