Ban the connect attr interpolateParams for MySQL 8 Vis dbs #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2024
rodrigozhou
requested changes
Feb 28, 2024
rodrigozhou
approved these changes
Feb 28, 2024
tdeebswihart
force-pushed
the
tds/prevent-mysql8-vis-interpolateParams
branch
from
b9fa8cc
to
302d324
Compare
There are a number of reasons why this doesn't work right now so we're going to prevent it from happening while we discuss whether we should invest in fixing it. The current work to fix this is in #5428
tdeebswihart
force-pushed
the
tds/prevent-mysql8-vis-interpolateParams
branch
from
302d324
to
768fd95
Compare
rodrigozhou
approved these changes
Mar 8, 2024
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Mar 21, 2024
…o#5441) ## What changed? Attempting to configure a MySQL 8 Visibility database with go-sql-driver/mysql's `interpolateParams` option will now fail. ## Why? There are a number of reasons why this doesn't work right now so we're going to prevent it from happening while we discuss how much we should invest in fixing it. The current work to fix this is in temporalio#5428 ## How did you test it? Added a new test ## Potential risks There should be none. Any user who has currently set up their database this way will already have encountered exciting errors like `Cannot create a JSON value from a string with CHARACTER SET 'binary'` and `Unable to parse ExecutionStatus value from DB`. ## Is hotfix candidate? That's up for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Attempting to configure a MySQL 8 Visibility database with go-sql-driver/mysql's
interpolateParamsoption will now fail.Why?
There are a number of reasons why this doesn't work right now so we're going to prevent it from happening while we discuss how much we should invest in fixing it. The current work to fix this is in #5428
How did you test it?
Added a new test
Potential risks
There should be none. Any user who has currently set up their database this way will already have encountered exciting errors like
Cannot create a JSON value from a string with CHARACTER SET 'binary'andUnable to parse ExecutionStatus value from DB.Is hotfix candidate?
That's up for discussion