Refactor handler for workflowIdReusePolicy #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
refactor-workflow-id-reuse
branch
2 times, most recently
from
bb23225
to
e7f57b5
Compare
stephanos
commented
Mar 5, 2024
stephanos
commented
Mar 5, 2024
stephanos
commented
Mar 5, 2024
stephanos
commented
Mar 5, 2024
stephanos
changed the title
stephanos
force-pushed
the
refactor-workflow-id-reuse
branch
from
224e14e
to
5182732
Compare
stephanos
commented
Mar 5, 2024
stephanos
commented
Mar 5, 2024
yycptt
approved these changes
Mar 7, 2024
stephanos
added a commit
to stephanos/temporal
that referenced
this pull request
Mar 21, 2024
- clearer distinction between the behavior for closed and running workflows - name that isn't particular to workflowIdReusePolicy, but the more general issue of an "ID duplication" Preparing for changes from temporalio/api#359 by pulling this refactor in early, reducing the size of the change later. Existing tests + added a test for Terminate-if-Running earlier in temporalio#5483. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Preparing for changes from temporalio/api#359 by pulling this refactor in early, reducing the size of the change later.
How did you test it?
Existing tests + added a test for Terminate-if-Running earlier in #5483.
Potential risks
Documentation
Is hotfix candidate?