Validate normal TQ on sticky poll #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Mar 5, 2024
tdeebswihart
approved these changes
Mar 5, 2024
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 5, 2024
## What changed? Validate normal TQ on sticky poll ## Why? On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue. ## How did you test it? Manual test with invalid TQ. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Mar 21, 2024
## What changed? Validate normal TQ on sticky poll ## Why? On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue. ## How did you test it? Manual test with invalid TQ. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
## What changed? Validate normal TQ on sticky poll ## Why? On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue. ## How did you test it? Manual test with invalid TQ. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
## What changed? Validate normal TQ on sticky poll ## Why? On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue. ## How did you test it? Manual test with invalid TQ. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
tdeebswihart
pushed a commit
that referenced
this pull request
Mar 28, 2024
## What changed? Validate normal TQ on sticky poll ## Why? On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue. ## How did you test it? Manual test with invalid TQ. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Validate normal TQ on sticky poll
Why?
On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ on a sticky queue would still trigger a load for the invalid normal queue.
How did you test it?
Manual test with invalid TQ.
Potential risks
Documentation
Is hotfix candidate?