Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ChildExecutionInfo Persistence POGOs to Proto #616

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Convert ChildExecutionInfo Persistence POGOs to Proto #616

merged 2 commits into from
Jul 28, 2020

Conversation

shawnhathaway
Copy link
Contributor

What changed?

  • Removed ChildExecutionInfo and InternalChildExecutionInfo from the persistence pkg. Moved mutableState and the persistence interface to use persistenceblobs.ChildExecutionInfo.
  • Removed double serialization of started_event and initiated_event ; instead use correct HistoryEvent proto type

Why?

  • Double serialization is bad.
  • workflowMutableState needs to become a proto object

How did you test it?
Existing make tests

Potential risks
Wide test coverage on timeouts should catch this, behavioral changes are contained within persistence.

alexshtin
alexshtin approved these changes Jul 28, 2020
View reviewed changes
common/persistence/executionStore.go
SignalRequestedIDs: response.State.SignalRequestedIDs,
ReplicationState: response.State.ReplicationState,
Checksum: response.State.Checksum,
ChildExecutionInfos: response.State.ChildExecutionInfos,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChildExecutionInfos wasn't there at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the part I removed below.

@shawnhathaway shawnhathaway merged commit f2bf9b2 into temporalio:master Jul 28, 2020
@shawnhathaway shawnhathaway deleted the cei-collapse branch July 28, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@samarabbas samarabbas Awaiting requested review from samarabbas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnhathaway @alexshtin