Default NumTaskqueue*Partitions to 4, use this value when listing partitions

[markmark206]

What changed?

Fix tctl tq lp command to return the list of partititions, based on config.NumTasklistWritePartitions. Default config.NumTasklistWritePartitions to 4, which gives us a reasonable default behavior.

Why?

Fixing a bug (incomplete implementation?), where the functionality of listing partitions was disassociated from its configuration parameters.

How did you test it?

I tested using cli:

  ~/src/temporal $ ./tctl --ns benchtest tq lp --tq temporal-bench
     WORKFLOWTASKQUEUEPARTITION    |      HOST
  temporal-bench                   | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/1 | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/2 | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/3 | 127.0.0.1:7235
     ACTIVITYTASKQUEUEPARTITION    |      HOST
  temporal-bench                   | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/1 | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/2 | 127.0.0.1:7235
  /__temporal_sys/temporal-bench/3 | 127.0.0.1:7235

Potential risks

If any code relies on the old behavior (which doesn't seem likely, since the old behavior was broken), it will need to be updated.

[mastermanu]

is it possible to add some form of unit testing to cover this?

[markmark206]

is it possible to add some form of unit testing to cover this?

Ah yes, thank you for mentioning tests!

We should def have unit tests for ListTaskQueuePartitions. I spend a bit of time looking into adding one, however, I ran into a problem passing a mock namespace into ListTaskQueuePartitionsRequest.

--- FAIL: TestMatchingEngineSuite (3.90s)
    --- FAIL: TestMatchingEngineSuite/TestListTaskQueuePartitions (0.00s)
        matchingEngine.go:655: Unexpected call to *cache.MockNamespaceCache.GetNamespaceID([chicken]) at /Users/markmark/src/temporal-mm/common/cache/namespaceCache_mock.go:141 because: there are no expected calls of the method "GetNamespaceID" for that receiver

It seems like there is a bit of work that needs to happen to enable this. I will look into adding that as a separate change, probably after Code Complete.

In the meantime, we will have our cicd pipelines exercise this functionality via tctl cli.