-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Proto Double Serialization, VersionHistories Column Cassandra #624
Conversation
} | ||
|
||
state = ReplicationStateFromProtos(protoInfo, protoReplVersions) | ||
} | ||
|
||
return info, state, nil | ||
// var vh *history.VersionHistories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these are commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case these tests fail :) I removed fetching it from the column and used the proto object that is stored already
@@ -427,6 +426,9 @@ func (h *VersionHistories) Duplicate() *VersionHistories { | |||
|
|||
// ToProto return thrift format of version histories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like thrift got a major upgrade!
What changed?
Why?
How did you test it?