Adds override for individual fields on activity retry policy #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfateev
approved these changes
Jul 29, 2020
alexshtin
approved these changes
Jul 29, 2020
mfateev
reviewed
Jul 29, 2020
|
|
||
| if merged.GetMaximumIntervalInSeconds() == 0 { | ||
| merged.MaximumIntervalInSeconds = defaultPolicy.GetMaximumIntervalInSeconds() | ||
| } |
There was a problem hiding this comment.
The maximum interval should be calculated based on the initial interval. The default of 100 seconds with initial interval of 3600 doesn't make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing behavior: If the retryPolicy struct on ScheduleActivity is nil, override with the default. Otherwise, take 100% of the retry Policy.
Desired behavior: For each field on the retryPolicy, if the individual value is not-set ('0'), then override with the default.
Testing: Extensive unit test coverage