Sets default activity maximum retry interval to be 100x minimum retry interval #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfateev
approved these changes
Jul 29, 2020
| } | ||
|
|
||
| if merged.GetMaximumIntervalInSeconds() == 0 { | ||
| merged.MaximumIntervalInSeconds = defaultPolicy.GetMaximumIntervalInSeconds() | ||
| merged.MaximumIntervalInSeconds = int32(defaultSettings.MaximumIntervalCoefficient * float64(merged.GetInitialIntervalInSeconds())) |
There was a problem hiding this comment.
It should be round up, but having that we are changing it anyway :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes situation where user sets an initial retry interval that is greater than 100 seconds, but doesn't explicitly set the maximum retry interval, which will lead to a validation failure when they try to start an activity.