Reset for workflows without completed tasks #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Aug 11, 2020
vitarb
changed the title
vitarb
force-pushed
the
reset-wo-completed-tasks
branch
from
1d8b6bc
to
996dcc5
Compare
mastermanu
reviewed
Aug 14, 2020
| for _, e := range be.Events { | ||
| eid++ | ||
| if e.GetEventId() != eid { | ||
| s.Fail(fmt.Sprintf("inconintous eventID: %v, %v", eid, e.GetEventId())) |
There was a problem hiding this comment.
[Nit] non-contiguous or non-continuous. Also, it is useful to add expected: and got: to the error message
There was a problem hiding this comment.
also, how could this happen?
There was a problem hiding this comment.
also curious when this would actually happen given we are the ones creating this mocked out data structure in the first place? We could have just assigned the eventTime variable inline for each event as well
There was a problem hiding this comment.
This can only happen if something is messed up in the reset logic in a way that creates gaps in event IDs. We do this check in other tests so it's there for consistency reasons.
mastermanu
approved these changes
Aug 14, 2020
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed an issue described in #494 allowing users to reset workflows without completed tasks.
In case if there is no completed task reset would use next event after workflow task scheduled event as a reset point.
It allows us to perform a reset on workflows that were unable to make any progress due to worker related issues.
Note that due to change in semantics two CLI parameters responsible for reset types were renamed: