Expose SQL Connection Options in docker template #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmark206
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
i didn't test this, and didn't verify that the values get picked up by the server, but otherwise the changes look good to me.
note that our helm chart don't currently use config_template.yaml, they generate config files "manually", so if we want systems deployed with helm charts to have access to this, that code needs to be updated as well.
https://github.com/temporalio/helm-charts/blob/3e59a5230768972e50fed8834ba4d1377a0dc8fe/templates/server-configmap.yaml#L94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Should be user configurable.
How did you test it?
No testing, looking at buildkite and pipeline stabilization.
Potential risks
Connection starvation