Sets default WorkflowExecutionTimeout and WorkflowRunTimeout on the request itself. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermanu
requested review from
samarabbas and
alexshtin
and removed request for
samarabbas
mastermanu
commented
Sep 25, 2020
mastermanu
commented
Sep 25, 2020
alexshtin
reviewed
Sep 25, 2020
samarabbas
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a Workflow, we auto fill-in "defaults" for Workflow Execution and Run Timeouts in the history service. Unfortunately, some aspects of the code (such as our retry logic) depends on the default value being filled in even when that auto fill-in logic has not yet been executed. This PR ensures that defaults are filled in at Workflow Start Request creation time to avoid this.
As an example, this was causing retries to not be executed with MaxAttempts = 0 if the user did not explicitly set the WorkflowExecutionTime.
Unit / Integration / Manual testing
Minimal risk, although in this situation, the user cannot change the WF timeout values for already running Workflows, which could be problematic (specifically for WorkflowTaskTimeout). Might consider removing that.