Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RDS Policies #1424

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Update RDS Policies #1424

merged 3 commits into from
Oct 19, 2022

Conversation

gaurav-gogia
Copy link
Contributor

  • Fixed cloudwatch log export policy - description was incorrect in terrascan policy
  • Added backup retention correct policy code to terrascan

@gaurav-gogia gaurav-gogia added new-policy policy Issue concerning policy maintainers. labels Oct 19, 2022
@gaurav-gogia gaurav-gogia requested a review from a team as a code owner October 19, 2022 03:57
@gaurav-gogia gaurav-gogia self-assigned this Oct 19, 2022
@shreyas-phansalkar-189
Copy link
Contributor

Needs an update with base branch

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1424 (b5a0bd3) into master (730c83f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files         279      279           
  Lines        7866     7866           
=======================================
  Hits         6084     6084           
  Misses       1424     1424           
  Partials      358      358

@gaurav-gogia
Copy link
Contributor Author

Needs an update with base branch

Updated with base branch

shreyas-phansalkar-189
shreyas-phansalkar-189 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@shreyas-phansalkar-189 shreyas-phansalkar-189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-gogia gaurav-gogia merged commit e289cc6 into tenable:master Oct 19, 2022
@gaurav-gogia gaurav-gogia deleted the update/rds-policies branch October 20, 2022 05:07
@krobertson3314 krobertson3314 mentioned this pull request Nov 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rchanger Rchanger Rchanger approved these changes

@shreyas-phansalkar-189 shreyas-phansalkar-189 shreyas-phansalkar-189 approved these changes

Assignees

@gaurav-gogia gaurav-gogia

Labels
new-policy policy Issue concerning policy maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaurav-gogia @shreyas-phansalkar-189 @codecov-commenter @Rchanger