support for terraform registry remote modules

[patilpankaj212]

1. Added remote module downloader for terraform registry
2. Fix issue - failure if the remote module itself has local modules

[codecov]

Codecov Report

Merging #505 (4ccc1d0) into master (ddb6f64) will increase coverage by 1.83%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   73.73%   75.57%   +1.83%     
==========================================
  Files          93       94       +1     
  Lines        2151     2227      +76     
==========================================
+ Hits         1586     1683      +97     
+ Misses        429      401      -28     
- Partials      136      143       +7     

Impacted Files	Coverage Δ
...viders/terraform/commons/remote-module-download.go	67.85% <67.85%> (ø)
pkg/iac-providers/terraform/commons/load-dir.go	82.85% <84.21%> (+0.16%)	⬆️
...iac-providers/terraform/commons/module-download.go	100.00% <100.00%> (ø)
pkg/policy/opa/engine.go	61.57% <0.00%> (+1.38%)	⬆️
.../iac-providers/terraform/commons/cty-converters.go	86.11% <0.00%> (+5.55%)	⬆️
pkg/iac-providers/terraform/commons/references.go	75.51% <0.00%> (+8.16%)	⬆️
...providers/terraform/commons/variable-references.go	81.66% <0.00%> (+16.66%)	⬆️
...ac-providers/terraform/commons/local-references.go	80.00% <0.00%> (+76.66%)	⬆️

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

Requested changes are already accommodated

[jlunaq]

Hi there,

Are the remote modules only downloadable from the official terraform registry? I need to download some modules from my private repos but it tries to read them locally.

[patilpankaj212]

Hello @jlunaq,
We support following remote backends - git, s3, gcs, http, terraform-registry
Could you please let us know where you have hosted your repo?
Can you please give an example of the source attribute in your module definition?

[jlunaq]

Hi @patilpankaj212 ,

Sorry for the late response, I haven't been notified.
The repo is in github, I found that terrascan is able to read the module when it is in the root directory.
So this issue is more related to the modules which are in a subdirectory, like this:

source = "[email protected]:company/module.git//modules/base?ref=v2.0.0"

In this case is where I'm getting the error

<nil>: Failed to read module directory; Module directory /Users/jluna/my-project/[email protected]:company/module.git/modules/roles does not exist or cannot be read.

[patilpankaj212]

Hello @jlunaq,
Thanks for doing the tests. Looks like a defect to me. Can you please open a issue for this case?

[jlunaq]

Sure, will do

[jlunaq]

#600

[patilpankaj212]

Thanks @jlunaq