Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the bug for google_kms_crypto_key policies #848

Conversation

shreyas-phansalkar-189
Copy link
Contributor

  • checkRotation90Days
  • checkRotation365Days

- checkRotation90Days
- checkRotation365Days
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #848 (475b88d) into master (d242c2e) will increase coverage by 5.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   73.18%   78.29%   +5.11%     
==========================================
  Files         110      164      +54     
  Lines        3170     4359    +1189     
==========================================
+ Hits         2320     3413    +1093     
- Misses        668      730      +62     
- Partials      182      216      +34     
Impacted Files Coverage Δ
...ac-providers/terraform/commons/local-references.go 71.87% <0.00%> (-8.13%) ⬇️
pkg/writer/human_readable.go 78.68% <0.00%> (-8.11%) ⬇️
pkg/config/global.go 79.45% <0.00%> (-7.09%) ⬇️
pkg/config/config-reader.go 80.64% <0.00%> (-6.32%) ⬇️
pkg/policy/opa/engine.go 59.36% <0.00%> (-6.20%) ⬇️
pkg/utils/severity.go 94.11% <0.00%> (-5.89%) ⬇️
pkg/iac-providers/kubernetes/v1/load-file.go 71.87% <0.00%> (-4.13%) ⬇️
pkg/iac-providers/tfplan/v1/load-file.go 74.19% <0.00%> (-3.59%) ⬇️
...providers/terraform/commons/variable-references.go 78.46% <0.00%> (-3.51%) ⬇️
pkg/utils/json.go 68.75% <0.00%> (-2.68%) ⬇️
... and 86 more

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shreyas-phansalkar-189 shreyas-phansalkar-189 merged commit 0eae483 into tenable:master Jun 9, 2021
@shreyas-phansalkar-189 shreyas-phansalkar-189 deleted the bugfix/kmsPolicyBugfix branch June 9, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants