-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add update delete protect #2037
Conversation
"delete_protect": { | ||
Type: schema.TypeBool, | ||
Optional: true, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有read, 为什么要computed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog还没有?
@@ -642,7 +648,33 @@ func resourceTencentCloudClbInstanceCreate(d *schema.ResourceData, meta interfac | |||
return err | |||
} | |||
} | |||
|
|||
if v, ok := d.GetOk("delete_protect"); ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样写false是进不去的
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", | ||
logId, mRequest.GetAction(), mRequest.ToJsonString(), mResponse.ToJsonString()) | ||
requestId := *mResponse.Response.RequestId | ||
retryErr := waitForTaskFinish(requestId, meta.(*TencentCloudClient).apiV3Conn.UseClbClient()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个操作是异步操作?
@@ -739,6 +770,7 @@ func resourceTencentCloudClbInstanceUpdate(d *schema.ResourceData, meta interfac | |||
internet := clb.InternetAccessible{} | |||
changed := false | |||
isLoadBalancerPassToTgt := false | |||
isDeleteProtect := false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么要给个默认值?
No description provided.