Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(waf): [] support post_cls_action, post_ckafka_action params #2517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SevenEarth
Copy link
Collaborator

fix/waf

@SevenEarth SevenEarth added the run check run check label Feb 4, 2024
@SevenEarth SevenEarth changed the title fix/waf [WIP]fix/waf Feb 4, 2024
@SevenEarth
Copy link
Collaborator Author

等待测试账号开通WAF权限测试

@SevenEarth SevenEarth closed this Apr 30, 2024
@SevenEarth SevenEarth reopened this Apr 30, 2024
@SevenEarth SevenEarth changed the title [WIP]fix/waf fix(waf): [] support post_cls_action, post_ckafka_action params Apr 30, 2024
"post_cls_action": {
Type: schema.TypeInt,
Optional: true,
Default: POST_CLS_ACTION_0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里一定要设置 default 属性吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 这里我去掉

"post_ckafka_action": {
Type: schema.TypeInt,
Optional: true,
Default: POST_CKAFKA_ACTION_0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 这里我去掉

@@ -9,7 +9,7 @@ import (
)

// go test -i; go test -test.run TestAccTencentCloudWafSaasDomainResource_basic -v
func TestAccTencentCloudWafSaasDomainResource_basic(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里自动化测试用例不能跑吗

@@ -9,7 +9,7 @@ import (
)

// go test -i; go test -test.run TestAccTencentCloudWafClbDomainResource_basic -v
func TestAccTencentCloudWafClbDomainResource_basic(t *testing.T) {
func TestAccTencentCloudNeedFixWafClbDomainResource_basic(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的自动化测试用例不能跑吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants