fix: (balance) 🐛 fixed multiple balance load bug

[Zfinix]

Fixed bug causing the balanceList to load and update multiple times in _fetchWalletBalances() and in

  set selectedWalletIndex(int? value) {
    if (selectedWalletIndex != value) {
      Action(() => _selectedWalletIndex.value = value)();
      getBalances(selectedWallet.publicAddress); /// this line refreshes the balance list when the wallet index is set
    }
  }

fixes #210

[andrzejchm]

awesome work! just two minor comments ad we're good to go

[andrzejchm]

as a rule of a thumb, let's extract user interaction code to a separate method, outside of the build method for readability:

Suggested change

	onTapDone: () async {
	unawaited(
	Navigator.of(context).pushAndRemoveUntil(
	MaterialPageRoute(
	builder: (_) => const AssetsPortfolioPage(),
	),
	(route) => false,
	),
	);
	await StarportApp.walletsStore.getBalances(selectedWallet.publicAddress);
	},
	onTapDone: onTapDone,

[Zfinix]

True

[Zfinix]

done

[andrzejchm]

this one is still not updated

[Zfinix]

sorry about that didnt push the commit

[Zfinix]

you can check it out now

[andrzejchm]

the rule for naming the user event methods is to call them _onTap{what} _onLongPress{what}, onSwipe{{what} and then within the method we decide what to do with the action. this way its a bit easier to comprehend the intention of the method and eventually modifying the logic inside of it does not require us to rename it

[Zfinix]

Ahh I see I mostly default to using the handle {what} method no problem will modify and follow this, Is there a way we can document these project rules and all.

[andrzejchm]

🚀

[Zfinix]

🚀

Do i need to wait for @wal33d006 to approve?

[andrzejchm]

I'll merge this one as Waleed is unavailable at the moment, but in the future let's give him a chance to review the code before merging :)

[Zfinix]

I'll merge this one as Waleed is unavailable at the moment, but in the future let's give him a chance to review the code before merging :)
Sure always 🙌🏾