Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (chain name) added chan chain name to UI #223

Merged
merged 10 commits into from
Mar 3, 2022
Merged

Conversation

Zfinix
Copy link
Contributor

@Zfinix Zfinix commented Feb 28, 2022

Fetches chain name from the node info and shows it in the UI (Onboarding screen).

Closes #207

@Zfinix Zfinix self-assigned this Feb 28, 2022
Copy link
Contributor

@andrzejchm andrzejchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing :)

starport_template/lib/utils/node_info.dart Outdated Show resolved Hide resolved
@Zfinix Zfinix requested a review from andrzejchm March 3, 2022 08:58
@@ -0,0 +1,21 @@
import 'dart:convert';

import 'package:http/http.dart' as http;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also rename the file to node_info_loader.dart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@andrzejchm andrzejchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 👏🏻

@Zfinix Zfinix merged commit da5e20b into main Mar 3, 2022
@Zfinix Zfinix deleted the fix/add-chain-name branch March 3, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace chain ID on the welcome screen
3 participants