refactor: Rename wallet to account #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wal33d006
added
Technical 🛠
wal33d006
changed the title
andrzejchm
reviewed
Mar 3, 2022
There was a problem hiding this comment.
good job! Since this is a public package used by other developers, we need to provide a migration guide for them, let's add a changelog file with small section of migration guide for versions older than 2.0.3 stating all the classes that have changed their names
|
Updated Added previous change logs by simply picking up points from releases, most of which are not related to this package. Let me know if we need to remove them and add something else entirely. |
andrzejchm
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
@wal33d006 great work, thanks for taking care of the changelog!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big PR, nothing fancy just renamed everything that was possible.