-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: created config base env file #244
Conversation
This looks good for a small config, but would it scale? For example, one of the things we'll add is fee configuration (see Keplr for example). It might look something like this: fees:
- denom: uosmo
amount:
low: 1000
normal: 3000
fast: 4000
- denom: uion
amount:
low: 10
normal: 20
fast: 40 Here's the amount of configuration Keplr requires: |
I believe it would scale, the problem here is that we don't want to build a parser for that structure and we want to be able to still use |
…flutter into feat/add-config-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrzejchm i also added updates to the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job @Zfinix ! Its much cleaner now. one comment and we're good to merge
|
||
class AppConfig { | ||
AppConfig({ | ||
this.lcdUrl = 'http://10.0.2.2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0.2.2
- localhost for android emulatorslhttp://localhost
- ios simulator
you'll have to stick with only 1 version, I suggest going with http://localhost
for both LCD and grpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
This is ready to be merged guys @wal33d006 @andrzejchm |
please merge at your convenience as soon as the CI checks pass :) |
Merging this now |
Closes #238