feat: create cosmos_node_client package #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready guys |
andrzejchm
suggested changes
Apr 28, 2022
.github/workflows/pull-request.yml
Outdated
Comment on lines
90
to
93
| # - name: cosmos_node_client - tests | ||
| #working-directory: packages/cosmos_node_client | ||
| #if: env.cosmos_node_client == 'true' | ||
| #run: flutter test |
There was a problem hiding this comment.
any reason this is commented out?
There was a problem hiding this comment.
We don't have any tests right now and the ci fails because of that, once we add tests we would we'd it back.
There was a problem hiding this comment.
lets add one, even 2+2=4 test just to enable the CI from the beginning. you can always remove the test as soon as you add proper ones later on
| @@ -0,0 +1,228 @@ | |||
| include: package:lint/analysis_options.yaml | |||
There was a problem hiding this comment.
let's use cosmos_lint package here instead of specifying the rules again
There was a problem hiding this comment.
Yeah I'm going to do that just needed the previous PR to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255