Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update to Cosmos SDK v0.44.0 #310

Merged
merged 14 commits into from
Sep 27, 2021
Merged

refactor: update to Cosmos SDK v0.44.0 #310

merged 14 commits into from
Sep 27, 2021

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Sep 22, 2021

No description provided.

@lumtis lumtis linked an issue Sep 22, 2021 that may be closed by this pull request
@lumtis lumtis marked this pull request as draft September 22, 2021 16:38
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #310 (26cb22e) into develop (2d1b087) will not change coverage.
The diff coverage is 47.56%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #310   +/-   ##
========================================
  Coverage    10.75%   10.75%           
========================================
  Files          109      109           
  Lines        27744    27744           
========================================
  Hits          2983     2983           
  Misses       24693    24693           
  Partials        68       68           
Impacted Files Coverage Δ
x/campaign/keeper/grpc_query_campaign.go 80.64% <0.00%> (ø)
x/campaign/keeper/grpc_query_mainnet_account.go 81.25% <0.00%> (ø)
...paign/keeper/grpc_query_mainnet_vesting_account.go 83.33% <0.00%> (ø)
x/campaign/types/tx.pb.go 0.78% <0.00%> (ø)
x/launch/keeper/grpc_query_chain.go 81.25% <0.00%> (ø)
x/launch/keeper/grpc_query_genesis_account.go 83.33% <0.00%> (ø)
x/launch/keeper/grpc_query_genesis_validator.go 83.33% <0.00%> (ø)
x/launch/keeper/grpc_query_request.go 83.78% <0.00%> (ø)
x/launch/keeper/grpc_query_vesting_account.go 83.33% <0.00%> (ø)
x/profile/keeper/grpc_query_validator.go 82.85% <0.00%> (ø)
... and 13 more

@lumtis
Copy link
Contributor Author

lumtis commented Sep 24, 2021

I added a t.Skip() statement for the following tests:

campaign/client/cli/query_mainnet_account_test.go
campaign/client/cli/query_mainnet_vesting_account_test.go
launch/client/cli/query_request_test.go

When tested individually, the tests pass but when the whole cli package is tested, the initialization of the test network fails because the initGenesisof distribution module fails. Gonna put more details in a specific issue

I was unable to reproduce this genesis initialization failure with local testing so this seems to be related to the "github.com/cosmos/cosmos-sdk/testutil/network" package.

I think we can address this issue later on so we can already merge 0.44 for other PRs and avoid losing too much time.
cli tests are not critical compared to keeper and types tests and all tests pass individually
I'm creating a specific PR for it

@lumtis lumtis marked this pull request as ready for review September 24, 2021 09:01
Pantani
Pantani previously approved these changes Sep 24, 2021
@lumtis lumtis marked this pull request as draft September 24, 2021 15:21
@lumtis lumtis linked an issue Sep 24, 2021 that may be closed by this pull request
@lumtis lumtis marked this pull request as ready for review September 24, 2021 15:45
@lumtis
Copy link
Contributor Author

lumtis commented Sep 24, 2021

Issue above has been fixed, for more information: #312

@lumtis lumtis merged commit 5278e9a into develop Sep 27, 2021
@lumtis lumtis deleted the refactor/0.44 branch September 27, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test network fails to initialize for some cli tests Update Cosmos SDK to v0.44
3 participants