Added RequestBeginBlock.IsProofBlock for create_empty_blocks=false

[TobiaszCudnik]

Description

Closes: cosmos-sdk#10240

This PR extends abci.RequestBeginBlock with IsProofBlock, used when create_empty_blocks=false.

Main changes in:

• consensus/state.go
• proto/tendermint/abci/types.proto

The IsProofBlock flag is used by modules in BeginBlockers to avoid write ops for those blocks. "Proof blocks" happen when:

• no txs in the mempool
• current apphash differs form the prev block's apphash
• empty blocks should NOT be created

"Proof block" is currently defined in tendermint/consensus/state.go:1041:

tendermint/consensus/state.go

Lines 1039 to 1049 in 35581cf

	// needProofBlock returns true on the first height (so the genesis app hash is signed right away)
	// and where the last block (height-1) caused the app hash to change
	func (cs *State) needProofBlock(height int64) bool {
	if height == cs.state.InitialHeight {
	return true
	}
	lastBlockMeta := cs.blockStore.LoadBlockMeta(height - 1)
	if lastBlockMeta == nil {
	panic(fmt.Sprintf("needProofBlock: last block meta for height %d not found", height-1))
	}

and used for create_empty_blocks in enterNewRound:

tendermint/consensus/state.go

Lines 1028 to 1035 in 35581cf

	waitForTxs := cs.config.WaitForTxs() && round == 0 && !cs.needProofBlock(height)
	if waitForTxs {
	if cs.config.CreateEmptyBlocksInterval > 0 {
	cs.scheduleTimeout(cs.config.CreateEmptyBlocksInterval, height, round,
	cstypes.RoundStepNewRound)
	}
	} else {
	cs.enterPropose(height, round)

Related links

• PR for Cosmos SDK
• Ticket 10240
• Ticket 12356

TODO

• regression test

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.