Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmos/gorocksdb in the imports #214

Merged
merged 5 commits into from
Jan 30, 2022
Merged

cosmos/gorocksdb in the imports #214

merged 5 commits into from
Jan 30, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 25, 2022 •
edited
Loading

  • updates .golangci-lint.yml
  • uses cosmos/gorocksdb everywhere preventing replace statements downstream
  • removes the version number from golanci-lint so that we're always using the latest version (earlier one was dated and it couldn't run because it didn't recognize revive)

creachadair
creachadair approved these changes Jan 25, 2022
View reviewed changes
common_test.go Outdated Show resolved Hide resolved
common_test.go Outdated Show resolved Hide resolved
faddat and others added 2 commits January 30, 2022 18:02
@faddat @creachadair
Update common_test.go
0008718 
Co-authored-by: M. J. Fromberger <[email protected]>
@faddat @creachadair
Update common_test.go
ca60244 
Co-authored-by: M. J. Fromberger <[email protected]>
@faddat
Copy link
Contributor Author

faddat commented Jan 30, 2022

makes sense and thanks!

@creachadair creachadair merged commit ce3673b into tendermint:master Jan 30, 2022
@baabeetaa baabeetaa deleted the gorocksdb branch January 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creachadair creachadair creachadair approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@cmwaters cmwaters Awaiting requested review from cmwaters

@tychoish tychoish Awaiting requested review from tychoish

@williambanfield williambanfield Awaiting requested review from williambanfield

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @creachadair @tac0turtle