This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
softsign: Fix private key decoding + import command (closes #290) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the inconsistencies between Base64 and binary/"raw" private keys, and adds key conversion which can take a `priv_validator.json` file or a "raw" (i.e. binary) private key and convert it to the Base64 format used by the `softsign` backend. Additionally, it adds a `key_format` configuration option allowing it to load private keys from any of the supported key formats. This should be sufficient to resolve the problems in #290, although I also plan on making the private key format a configuration option.
tarcieri
force-pushed
the
softsign/import-bugfixes-and-subcommand
branch
from
28baf54
to
f324201
Compare
This was referenced Jul 25, 2019
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the inconsistencies between Base64 and binary/"raw" private keys, and adds key conversion which can take a
priv_validator.jsonfile or a "raw" (i.e. binary) private key and convert it to the Base64 format used by thesoftsignbackend.Additionally, it adds a
key_formatconfiguration option allowing itto load private keys from any of the supported key formats.
This should be sufficient to resolve the problems in #290, although I also plan on making the private key format a configuration option.