-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added R wrappers for released dataset ops #40
Conversation
19a195d
to
54574a0
Compare
@yongtang Just rebased and resolved conflicts. Could you take a look when you get a chance? |
I don't have a lot of experience with R other than some brief knowledge many year ago. I tried locally but had the error:
I am wondering if there is a simple readme about the usage? I think |
Good call. I’ll add some test cases and instructions (maybe on top of your README PR). I am marking this PR as WIP for now and will ping when ready. |
Thanks @terrytangyuan. The repo have a simple sequence file: The sample sequence file consists of key-value pairs: io/tensorflow_io/hadoop/python/kernel_tests/hadoop_test.py Lines 37 to 41 in fc10234
Let me know if I can be of any help. I am interested in playing with R as well 😃 |
54574a0
to
8db6829
Compare
@yongtang Thanks. I fixed the error you encountered and added instruction to README.md as an alternative to the instruction you added in the other PR. Also added a very simple test case (we can add more strict ones later). I haven't used |
@terrytangyuan I tried locally and it works. Thanks! We could add some additional test cases later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is on top of #39. The wrappers were scaffolded using scripts created in #39 and then manually edited for cosmetic purposes as well as additional checks for arguments.
tfdatasets
package sotfio
would play nicely withtfdatasets
.R CMD check
errors and warnings.This is part of #6.