Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projector plugin links in docs #3561

Merged
merged 1 commit into from
May 12, 2020

Conversation

ricmatsui
Copy link
Contributor

  • Motivation for features / changes

Links in projector plugin notebook were copied from image summaries notebook without changing so they are incorrect.

  • Technical description of changes

Fixes links to link to the project plugin notebook

  • Screenshots of UI changes

Screen Shot 2020-04-29 at 12 59 26 AM

  • Detailed steps to verify changes work correctly (as executed by you)

Click on the links to view the notebook and verify they link to the projector plugin notebook

  • Alternate designs / implementations considered

N/A

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Copy link
Member

@davidsoergel davidsoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@davidsoergel davidsoergel merged commit a57c8a0 into tensorflow:master May 12, 2020
@ricmatsui ricmatsui deleted the rm-projector-links branch May 15, 2020 02:05
caisq pushed a commit to caisq/tensorboard that referenced this pull request May 19, 2020
caisq pushed a commit that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants