-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate boto3 1.13.1 range error code #3609
Tolerate boto3 1.13.1 range error code #3609
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
d489774
to
3a623cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ahirner It looks like your CLA signature wasn't registered for some reason. Can you please check per the instructions in the googlebot message above, and/or try signing again? Thanks! |
@googlebot I signed it! |
@ahirner Unfortunately the email address on the commit and the one you signed with are seemingly still not lining up. It looks like your commit originally used your @gmail.com address, but then switched to an autogenerated address @users.noreply.github.com (perhaps due to editing some part of it within the GitHub UI?). Please take a look at this GitHub help page re. which email address is used. You may need to rebase the commit to associate it with the correct address, too. Sorry for the hassle! |
Thanks for your support @davidsoergel, I think i forgot to change author name in my first rebase/push. Let me retry. |
3a623cd
to
08e78ca
Compare
08e78ca
to
d22bb8e
Compare
@googlebot rescan. |
@googlebot rescan.
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@ahirner Thanks for figuring that out, and thanks again for the fix! The remaining lint failure is clearly bogus, so I'll go ahead and merge this. |
fixes #3608