Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate boto3 1.13.1 range error code #3609

Merged
merged 1 commit into from
May 13, 2020

Conversation

ahirner
Copy link
Contributor

@ahirner ahirner commented May 9, 2020

fixes #3608

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ahirner
Copy link
Contributor Author

ahirner commented May 9, 2020

@googlebot I signed it!

Copy link
Member

@davidsoergel davidsoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidsoergel
Copy link
Member

@ahirner It looks like your CLA signature wasn't registered for some reason. Can you please check per the instructions in the googlebot message above, and/or try signing again? Thanks!

@ahirner
Copy link
Contributor Author

ahirner commented May 12, 2020

@googlebot I signed it!

@davidsoergel
Copy link
Member

@ahirner Unfortunately the email address on the commit and the one you signed with are seemingly still not lining up.

It looks like your commit originally used your @gmail.com address, but then switched to an autogenerated address @users.noreply.github.com (perhaps due to editing some part of it within the GitHub UI?). Please take a look at this GitHub help page re. which email address is used.

You may need to rebase the commit to associate it with the correct address, too. Sorry for the hassle!

@ahirner
Copy link
Contributor Author

ahirner commented May 12, 2020

Thanks for your support @davidsoergel, I think i forgot to change author name in my first rebase/push. Let me retry.

@ahirner
Copy link
Contributor Author

ahirner commented May 12, 2020

@googlebot rescan.
Last change was to make the verified email associated with the private github address primary.
Would file issue if this doesn't work.

@ahirner
Copy link
Contributor Author

ahirner commented May 13, 2020

@googlebot rescan.
I'm the owner of my verified corporate and personal account. Its e-mail is associated in github. The patch shows the private address. There is no way to add specific contributors of my corporate account under this link, only a "Manage my account" button. After this button there is no way to add specific contributors either [1], only a "Sign a new agreement" section. I tried to sign a new agreement on my personal account, and it led to editing the existing account. I changed its user name to github handle instead of the prior e-mail address of the private account.

Conclusion: there is no way to explicitly add contributors to a corporate account but there should be.
edit: There is [1] and the contributor was in the group, so i guess it eventually matched on the other account which is also fine

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@davidsoergel
Copy link
Member

@ahirner Thanks for figuring that out, and thanks again for the fix! The remaining lint failure is clearly bogus, so I'll go ahead and merge this.

@davidsoergel davidsoergel merged commit 06685ec into tensorflow:master May 13, 2020
caisq pushed a commit to caisq/tensorboard that referenced this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 range error is not caught
3 participants